[PATCH] D67572: [SVFS] The Search Vector Function System.

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 5 11:06:33 PST 2019


fpetrogalli marked an inline comment as done.
fpetrogalli added inline comments.


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:205-207
+    if (TLI && TLI->isFunctionVectorizable(ScalarName)) {
+      TLI->fixUpVFABINames(CI);
+    }
----------------
This method `fixUpVFABINames` could be invoked once directly in the LoopVectorizer (runOnFunction), so that:

1. it avoids calling it every time the SVFS is instantiated, by doing it once for all the calls in the module (or function).
2. it allows the SVFS to be independent on the TLI.

This seems a better solution to me - any opinions?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67572/new/

https://reviews.llvm.org/D67572





More information about the llvm-commits mailing list