[PATCH] D69777: [ConstantFolding] Fold calls to FP remainder function

Ehud Katz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 5 10:56:53 PST 2019


ekatz marked an inline comment as done.
ekatz added inline comments.


================
Comment at: llvm/test/Analysis/ConstantFolding/math-2.ll:31
+}
+
 declare double @pow(double, double)
----------------
arsenm wrote:
> ekatz wrote:
> > arsenm wrote:
> > > Should have tests stressing all the handled types , and preferably a few for the special cases , like snan 
> > I agree that it should be tested for `double` as well, but the test cases are not important, as we test them under the APFloat unit-test. Otherwise, we will just have duplicates in the implementation code and the using code.
> The code specifically checks for opStatus though, so the point isn't necessarily then folding result
The APFloat unit test is also testing various combination of operations' results.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69777/new/

https://reviews.llvm.org/D69777





More information about the llvm-commits mailing list