[llvm] 82588e0 - [SLP] - Add couple safety checks to TreeEntry::dump(). NFC

Sergey Dmitriev via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 5 10:34:32 PST 2019


Author: Sergey Dmitriev
Date: 2019-11-05T09:57:30-08:00
New Revision: 82588e05cc32bb30807e480abd4e689b0dee132a

URL: https://github.com/llvm/llvm-project/commit/82588e05cc32bb30807e480abd4e689b0dee132a
DIFF: https://github.com/llvm/llvm-project/commit/82588e05cc32bb30807e480abd4e689b0dee132a.diff

LOG: [SLP] - Add couple safety checks to TreeEntry::dump(). NFC

Summary: Check for MainOp and AltOp for NULL before dereferencing or issue NULL.

Reviewers: Vasilis, dtemirbulatov, RKSimon, ABataev

Reviewed By: ABataev

Subscribers: mehdi_amini, hiraditya, dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69812

Added: 
    

Modified: 
    llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index 94392ca6a4a5..76357e11b8c5 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -1355,14 +1355,21 @@ class BoUpSLP {
       for (Value *V : Scalars)
         dbgs().indent(2) << *V << "\n";
       dbgs() << "NeedToGather: " << NeedToGather << "\n";
-      dbgs() << "MainOp: " << *MainOp << "\n";
-      dbgs() << "AltOp: " << *AltOp << "\n";
+      dbgs() << "MainOp: ";
+      if (MainOp)
+        dbgs() << *MainOp << "\n";
+      else
+        dbgs() << "NULL\n";
+      dbgs() << "AltOp: ";
+      if (AltOp)
+        dbgs() << *AltOp << "\n";
+      else
+        dbgs() << "NULL\n";
       dbgs() << "VectorizedValue: ";
       if (VectorizedValue)
-        dbgs() << *VectorizedValue;
+        dbgs() << *VectorizedValue << "\n";
       else
-        dbgs() << "NULL";
-      dbgs() << "\n";
+        dbgs() << "NULL\n";
       dbgs() << "ReuseShuffleIndices: ";
       if (ReuseShuffleIndices.empty())
         dbgs() << "Emtpy";


        


More information about the llvm-commits mailing list