[PATCH] D69721: [RISCV] Add CFI-related tests

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 4 11:17:16 PST 2019


luismarques marked 5 inline comments as done.
luismarques added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/vararg.ll:1766
+
+; TODO: also use the split-sp update approach for varargs
+
----------------
lenary wrote:
> This TODO should go into `RISCVFrameLowering.cpp`, not the tests.
This was actually not a split-sp issue, but a more general issue of constant materialization of stack addresses. Updated the comment. Given the broader scope, I'm letting it remain simply as a test comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69721/new/

https://reviews.llvm.org/D69721





More information about the llvm-commits mailing list