[PATCH] D69593: [libFuzzer] don't use /dev/null for DiscardOuput in Fuchsia.

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 4 18:29:28 PST 2019


kcc added a comment.

please avoid #ifdefs -- they are pure evil. 
Can you move this function to FuzzerUtil*.cpp? 
In this case it will have it's own implementation in FuzzerUtilFuchsia.cpp

It sucks in a different way, but less than using #ifdefs


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69593/new/

https://reviews.llvm.org/D69593





More information about the llvm-commits mailing list