[PATCH] D69812: [SLP] - Add couple safety checks to TreeEntry::dump(). NFC

Valeriy Dmitriev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 4 14:26:31 PST 2019


vdmitrie added a comment.

In D69812#1733047 <https://reviews.llvm.org/D69812#1733047>, @ABataev wrote:

> Something like `llvm/unittests/IR/DominatorTreeBatchUpdatesTest.cpp`?


Thank you Sir, but the test you pointed looks overcomplicated for the purpose of testing this debug printer. Why did not you request unit test for example here (https://reviews.llvm.org/D59059)  when the dump routine was initially implemented?

As a LIT test it could look like this:
F10626901: slp_dump_vec_tree.ll <https://reviews.llvm.org/F10626901>

But it cannot be added this way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69812/new/

https://reviews.llvm.org/D69812





More information about the llvm-commits mailing list