[PATCH] D69812: [SLP] - Add couple safety checks to TreeEntry::dump(). NFC

Valeriy Dmitriev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 4 12:22:26 PST 2019


vdmitrie added a comment.



>> Do you have any ideas how a test might look?
> 
> unittests?

I did not mean test's shape when asked the question.  This dump routine only called from dumpVectorizableTree routine which in turn is never called in the code. It exists to support debugging.
I can imagine adding "gdb --args opt ..." test with gdb script to call mentioned routine but think it is overkill for this sort of change.
It would be great if you could point an existing test case that intended to test similar issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69812/new/

https://reviews.llvm.org/D69812





More information about the llvm-commits mailing list