[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

[Fady Ghanim via Phabricator via llvm-commits]

fghanim added inline comments.


================
Comment at: llvm/include/llvm/IR/OpenMPIRBuilder.h:51
+  /// potentially other helpers into the underlying module. Must be called
+  /// before any other other method and only once!
+  void initialize();
----------------
///before any other method and only once!


================
Comment at: llvm/include/llvm/IR/OpenMPIRBuilder.h:72
+                      bool CheckCancelFlag = true);
+
+  ///}
----------------
Suggestion: Rename to createOMPBarrier( ... ); - similar naming scheme to IRBuilder, MDBuilder, etc.


================
Comment at: llvm/lib/IR/OpenMPIRBuilder.cpp:169
+void OpenMPIRBuilder::emitOMPBarrier(const LocationDescription &Loc,
+                                     DirektiveKind DK, bool CheckCancelFlag) {
+  assert(Loc.IP.getBlock() && "No insertion point provided!");
----------------
DirectiveKind


================
Comment at: llvm/lib/IR/OpenMPIRBuilder.cpp:177
+void OpenMPIRBuilder::emitBarrierImpl(const LocationDescription &Loc,
+                                      DirektiveKind Kind, bool CheckCancelFlag,
+                                      bool ForceSimpleCall) {
----------------
DirectiveKind


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69785/new/

https://reviews.llvm.org/D69785