[PATCH] D69672: DWARFDebugLoclists: Move to a incremental parsing model

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 4 10:00:30 PST 2019


labath marked an inline comment as done.
labath added a comment.

Will address @dblaikie's comments tomorrow.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:121
 
     bool UseLocLists = !U->isDWOUnit();
     auto Data = [&] {
----------------
SouraVX wrote:
> @labath , Not sure about this piece of code, is this patch has some relationship with D68271 ?? 
> I noticed this piece of code their, and which is uncommitted ??
Yes, it is based on that patch, mainly because I was too lazy to create a new branch for this work. What is it that you are unsure of? (Is it just it's presence, or something more?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69672/new/

https://reviews.llvm.org/D69672





More information about the llvm-commits mailing list