[PATCH] D69775: [Scheduling][ARM] Consistently enable PostRA Machine scheduling

[Dave Green via Phabricator via llvm-commits]

dmgreen marked an inline comment as done.
dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:389
+  // Don't reschedule potential IT blocks.
+  return !isThumb1Only();
+}
----------------
samparker wrote:
> I know this is the existing logic, but what are we trying to do here with respect to IT blocks? If we're worried about IT blocks, like the comment suggests, shouldn't we be returning isThumb1Only()? Also, if we're in arm mode then we won't have them, but are we still concerned about predicated instructions (I assume not)? 
I think the comment should really say something like "Thumb1 cores are too simple to benefit from scheduling". I'm not sure what it means by IT blocks.

I will change that. I don't think it would be particularly bad thing to do post-ra scheduling on thumb1 cores, it just won't benefit from it either, so we might as well save the compile time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69775/new/

https://reviews.llvm.org/D69775