[PATCH] D69437: [RAGreedy] Enable -consider-local-interval-cost by default

Zhang Kang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 3 03:32:21 PST 2019


ZhangKang added a comment.

In D69437#1728336 <https://reviews.llvm.org/D69437#1728336>, @dmgreen wrote:

> Hmm. That's interesting. I'm guessing the flags you use between base and peak are quite different? The only consistent results was exchange2_r, which was getting better! How noisy are these results? What kind of a confidence interval do you have?
>
> It may be simpler to make this AArch64 only instead, same as the X86 backend previously had. We know that there it fixes the issue with repeatedly spilling registers, and the performance is otherwise not largely effected.


@jsji @dmgreen , I have check the result on PPC. My old test result has used the wrong driver for some cases.
For spec base test, 3 cases downgraded more than 1%, the biggest is -4.55%. Only one case upgraded more than 1%(2.27%).
For spec peak test, 3 cases downgraded more than 1%, the biggest is -3.48%. No case upgraded more than 1%.

This patch has bad impact on spec fp test, the geomean of fp base test downgraded 0.69%, and the geomean of fp peak test downgraded 0.43%.

So I would prefer we don't enable it by default for PowerPC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69437/new/

https://reviews.llvm.org/D69437





More information about the llvm-commits mailing list