[llvm] d801f79 - TargetParserTest - testARMArch - stop bitwise operators on boolean warnings. NFCI.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 2 15:41:04 PDT 2019


Author: Simon Pilgrim
Date: 2019-11-02T22:40:04Z
New Revision: d801f79419231481cda2980da4056714c788e7a8

URL: https://github.com/llvm/llvm-project/commit/d801f79419231481cda2980da4056714c788e7a8
DIFF: https://github.com/llvm/llvm-project/commit/d801f79419231481cda2980da4056714c788e7a8.diff

LOG: TargetParserTest - testARMArch - stop bitwise operators on boolean warnings. NFCI.

Ensure the test still runs all target checks but stop the static analyzer warnings.

Added: 
    

Modified: 
    llvm/unittests/Support/TargetParserTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/Support/TargetParserTest.cpp b/llvm/unittests/Support/TargetParserTest.cpp
index ca95bd5f794a..3dd0d9d28d87 100644
--- a/llvm/unittests/Support/TargetParserTest.cpp
+++ b/llvm/unittests/Support/TargetParserTest.cpp
@@ -322,10 +322,11 @@ TEST(TargetParserTest, testInvalidARMArch) {
 bool testARMArch(StringRef Arch, StringRef DefaultCPU, StringRef SubArch,
                  unsigned ArchAttr) {
   ARM::ArchKind AK = ARM::parseArch(Arch);
-  return (AK!= ARM::ArchKind::INVALID) &
-         ARM::getDefaultCPU(Arch).equals(DefaultCPU) &
-         ARM::getSubArch(AK).equals(SubArch) &
-         (ARM::getArchAttr(AK) == ArchAttr);
+  bool Result = (AK != ARM::ArchKind::INVALID);
+  Result &= ARM::getDefaultCPU(Arch).equals(DefaultCPU);
+  Result &= ARM::getSubArch(AK).equals(SubArch);
+  Result &= (ARM::getArchAttr(AK) == ArchAttr);
+  return Result;
 }
 
 TEST(TargetParserTest, testARMArch) {


        


More information about the llvm-commits mailing list