[PATCH] D68593: [NewPM] Add an SROA pass after loop unroll

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

Our bots started failing after this change landed with the following error:

  ******************** TEST 'Clang :: CodeGenCXX/union-tbaa2.cpp' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /b/s/w/ir/k/recipe_cleanup/clangSkDsbg/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clangSkDsbg/llvm_build_dir/lib/clang/10.0.0/include -nostdsysteminc /b/s/w/ir/k/llvm-project/clang/test/CodeGenCXX/union-tbaa2.cpp -O2 -std=c++11 -triple x86_64-unknown-linux-gnu -target-cpu x86-64 -target-feature +sse4.2 -target-feature +avx -emit-llvm -o - | /b/s/w/ir/k/recipe_cleanup/clangSkDsbg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/CodeGenCXX/union-tbaa2.cpp
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /b/s/w/ir/k/llvm-project/clang/test/CodeGenCXX/union-tbaa2.cpp:19:11: error: CHECK: expected string not found in input
  // CHECK: store <4 x double>
            ^
  <stdin>:1:1: note: scanning from here
  ; ModuleID = '/b/s/w/ir/k/llvm-project/clang/test/CodeGenCXX/union-tbaa2.cpp'
  ^
  <stdin>:6:33: note: possible intended match here
  @.str = private unnamed_addr constant [4 x i8] c"%f \00", align 1
                                  ^
  
  --

Our toolchain uses new PM by default which is presumably why it hasn't manifested on other bots. Can you quickly fix this or is it OK to revert the change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68593/new/

https://reviews.llvm.org/D68593