[PATCH] D69748: [Attributor][IPConstantProp] Run the Attributor on IPConstantProp tests

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 2 14:09:30 PDT 2019


fhahn added a comment.

As mentioned in D69747 <https://reviews.llvm.org/D69747> already, I am not too happy with the tests here to mix testing IPSCCP and IPConstantPropagation; I think it's valuable to just have a single target to run the relevant tests. Would it make sense to group the attributor tests together in a directory?

Also, unfortunately I did not have time to followd the attributor development closely lately, I am just curious: is there a benefit of doing some value simplifications in attributor directly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69748/new/

https://reviews.llvm.org/D69748





More information about the llvm-commits mailing list