[PATCH] D69747: [IPConstantProp][NFCI] Improve and modernize tests

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 2 13:41:52 PDT 2019


fhahn added a comment.

It seems some of those files test IPSCCP while others test the IPConstantPropagation pass. Having them both in there is a bit confusing. I think most IPSCCP tests live in test/Transforms/SCCP, which they share the code with. It might be worth to move the IPSCCP tests from IPConstantPropagation to test/Transforms/SCCP or create a new IPSCCP test directory.

And FWIW, I think we might want to consider removing the IPConstantPropagation pass, because it looks like it is not used in any pipelines and IPSCCP is more powerful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69747/new/

https://reviews.llvm.org/D69747





More information about the llvm-commits mailing list