[llvm] c0e83fa - ARMAttributeParser - fix shadow variable name warnings from decodeULEB128 calls. NFCI.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 2 13:13:17 PDT 2019


Author: Simon Pilgrim
Date: 2019-11-02T20:12:59Z
New Revision: c0e83fa5ac5093b31612d9134cb9d1eee0d813c2

URL: https://github.com/llvm/llvm-project/commit/c0e83fa5ac5093b31612d9134cb9d1eee0d813c2
DIFF: https://github.com/llvm/llvm-project/commit/c0e83fa5ac5093b31612d9134cb9d1eee0d813c2.diff

LOG: ARMAttributeParser - fix shadow variable name warnings from decodeULEB128 calls. NFCI.

Consistently rename the Length attribute to DecodeLength in decodeULEB128 calls.

Added: 
    

Modified: 
    llvm/lib/Support/ARMAttributeParser.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Support/ARMAttributeParser.cpp b/llvm/lib/Support/ARMAttributeParser.cpp
index df50fff720cd..8a89f4c45fb9 100644
--- a/llvm/lib/Support/ARMAttributeParser.cpp
+++ b/llvm/lib/Support/ARMAttributeParser.cpp
@@ -73,9 +73,9 @@ ARMAttributeParser::DisplayRoutines[] = {
 
 uint64_t ARMAttributeParser::ParseInteger(const uint8_t *Data,
                                           uint32_t &Offset) {
-  unsigned Length;
-  uint64_t Value = decodeULEB128(Data + Offset, &Length);
-  Offset = Offset + Length;
+  unsigned DecodeLength;
+  uint64_t Value = decodeULEB128(Data + Offset, &DecodeLength);
+  Offset += DecodeLength;
   return Value;
 }
 
@@ -587,9 +587,9 @@ void ARMAttributeParser::nodefaults(AttrType Tag, const uint8_t *Data,
 void ARMAttributeParser::ParseIndexList(const uint8_t *Data, uint32_t &Offset,
                                         SmallVectorImpl<uint8_t> &IndexList) {
   for (;;) {
-    unsigned Length;
-    uint64_t Value = decodeULEB128(Data + Offset, &Length);
-    Offset = Offset + Length;
+    unsigned DecodeLength;
+    uint64_t Value = decodeULEB128(Data + Offset, &DecodeLength);
+    Offset += DecodeLength;
     if (Value == 0)
       break;
     IndexList.push_back(Value);
@@ -599,9 +599,9 @@ void ARMAttributeParser::ParseIndexList(const uint8_t *Data, uint32_t &Offset,
 void ARMAttributeParser::ParseAttributeList(const uint8_t *Data,
                                             uint32_t &Offset, uint32_t Length) {
   while (Offset < Length) {
-    unsigned Length;
-    uint64_t Tag = decodeULEB128(Data + Offset, &Length);
-    Offset += Length;
+    unsigned DecodeLength;
+    uint64_t Tag = decodeULEB128(Data + Offset, &DecodeLength);
+    Offset += DecodeLength;
 
     bool Handled = false;
     for (unsigned AHI = 0, AHE = array_lengthof(DisplayRoutines);


        


More information about the llvm-commits mailing list