[PATCH] D69546: [SanitizerCommon] Print the current value of options when printing out help.

[Dan Liew via Phabricator via llvm-commits]

delcypher marked an inline comment as done.
delcypher added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_flag_parser.h:25
   virtual bool Parse(const char *value) { return false; }
+  virtual bool CurrentValueAsString(char *buffer, uptr size) {
+    buffer[0] = '\0';
----------------
yln wrote:
> I think this should really be an abstract method to force subclasses to implement it. Or if we can't make it abstract/pure virtual because compiler-rt is too special, then "not implemented".  Same thing holds for `Parse`, I guess.
I'm just copying the style of code that was there before. I'm not against what you suggest but I'd rather fix this in a follow-up patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69546/new/

https://reviews.llvm.org/D69546