[PATCH] D69461: [XRay] Sanitize DOT labels in graph output

Alex Cameron via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 1 20:12:22 PDT 2019


tetsuo-cpp marked an inline comment as done.
tetsuo-cpp added a comment.

I was running `2.40.1-6` which is identical (plus a CVE fix) but still couldn't get `dot` to error with a test program with templates. The output of `dot` looks correct for different formats (I was looking mainly at SVG and JSON) before and after this change.
So I'm still not 100% sure that you need this change since I haven't seen the problem first hand. But it doesn't hurt either way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69461/new/

https://reviews.llvm.org/D69461





More information about the llvm-commits mailing list