[PATCH] D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC)

Hideki Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 1 14:44:26 PDT 2019


hsaito added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:6991
+  if (Recipe) {
+    setRecipe(Instr, Recipe);
     VPBB->appendRecipe(Recipe);
----------------
I think the code here is easier to understand if written as

    if ((Recipe = tryToWiden...())     ||
        (Recipe = tryToOptimize...()) ||
        (Recipe = tryToBlend())         ||
        (isa<PHINode()> && (Recipe = new VPWidenPHIRecipe())) {
        setRecipe(Instr, Recipe);
    }



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68577/new/

https://reviews.llvm.org/D68577





More information about the llvm-commits mailing list