[PATCH] D69736: Keep import function list for inlinee profile update

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 1 13:35:03 PDT 2019


wenlei added a comment.

This is a minimal point fix (was trying to keep internal patch minimum), but it might actually make sense to have `setEntryCount` always copy over the existing import list (if it exists), instead of adding `updateEntryCount`? Or even further, we could have a separate metadata for the import list, instead of piggyback on `function_entry_count`? To me, it seems a bit weird to embed import list as part of `function_entry_count` - wondering what's the reason behind that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69736/new/

https://reviews.llvm.org/D69736





More information about the llvm-commits mailing list