[PATCH] D69724: [dexter] Remove lit check for python 3

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 1 11:36:44 PDT 2019


rnk created this revision.
rnk added a reviewer: jmorse.
Herald added a project: LLVM.

This is checking the version of Python used to run lit, which is not
necessarily the same as the version used to run the dexter tests.  If
the tests are run via the build/bin/llvm-lit[.py] helper script, then
that is likely to pick up whatever version of Python is on PATH.
Conventionally, this will find Python 2. CMake already checks that
Python 3 is in use and puts the path to it in the lit site config, so
this check is redundant, and Python 3 will ultimately be used to run
dexter.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69724

Files:
  debuginfo-tests/dexter/feature_tests/lit.local.cfg


Index: debuginfo-tests/dexter/feature_tests/lit.local.cfg
===================================================================
--- debuginfo-tests/dexter/feature_tests/lit.local.cfg
+++ debuginfo-tests/dexter/feature_tests/lit.local.cfg
@@ -1,8 +1,2 @@
 config.name = "DExTer feature tests"
 config.suffixes = ['.cpp', '.c', '.test']
-
-# Dexter requires python3
-
-import sys
-if sys.version_info.major < 3:
-    config.unsupported = True


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69724.227496.patch
Type: text/x-patch
Size: 439 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191101/331cb227/attachment.bin>


More information about the llvm-commits mailing list