[PATCH] D69660: [HardwareLoops] Optimisation remarks

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer updated this revision to Diff 227471.
SjoerdMeijer added a comment.

This is a pass manager's problem. By comparing the hardwareloop pass with other passes also using the optimisation remarks, I noticed a missing:

  INITIALIZE_PASS_DEPENDENCY(OptimizationRemarkEmitterWrapperPass)

which I have now added. I am fairly confident that this will solve the problem, but as I haven't been able to reproduce locally, I am not entirely certain.
Could I ask for one more favour, would you be able to verify this? If this doesn't solve it, I need to see why I can't reproduce this, but that is a bit of bigger task which I'm obviously trying to avoid... :-/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69660/new/

https://reviews.llvm.org/D69660

Files:
  llvm/lib/CodeGen/HardwareLoops.cpp
  llvm/test/CodeGen/ARM/O3-pipeline.ll
  llvm/test/Transforms/HardwareLoops/ARM/structure.ll
  llvm/test/Transforms/HardwareLoops/unconditional-latch.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69660.227471.patch
Type: text/x-patch
Size: 11116 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191101/a2ba4140/attachment.bin>