[PATCH] D69513: [GlobalISel] Widen one type at the time for insert/extract vector elt

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

I don't understand the motivation. The vector element and insert element type need to match, but it appears there's a missing verifier check



================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:1784
+      Observer.changingInstr(MI);
+      widenScalarSrc(MI, WideTy, 1, TargetOpcode::G_SEXT);
+      Observer.changedInstr(MI);
----------------
Petar.Avramovic wrote:
> G_INSERT_VECTOR_ELT uses G_ANYEXT for its vector TypeIdx (0). Should this one also use  G_ANYEXT?
This should probably be changed in a separate patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69513/new/

https://reviews.llvm.org/D69513