[PATCH] D69683: [Hurd]: use /proc/self/exe to get program path

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 1 09:49:26 PDT 2019


kristina added a comment.

Is there a better way to check for a Hurd host than using the `__GNU__` preprocessor macro? I'm worried it may cause some confusion otherwise similar to the issue with Hurd triples. It seems that Hurd target defines `__gnu_hurd__`, which is a lot less ambiguous and probably self-explanatory than `__GNU__` (especially considering how often `__GNUC__` is defined and given that it has a completely different meaning). Aside from that, LGTM!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69683/new/

https://reviews.llvm.org/D69683





More information about the llvm-commits mailing list