[PATCH] D69500: [X86] NFC: Convert LLVM command-line flag to target attribute

David Zarzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 1 05:12:14 PDT 2019


davezarzycki added a comment.

In D69500#1728720 <https://reviews.llvm.org/D69500#1728720>, @craig.topper wrote:

> Doesn’t this leave the FastPartialWriteFlag unused?
>
> With this change there is no way to disable the pass from the clang command line.


Yes, this leaves FeatureFastPartialYMMorZMMWrite unused. I looked into wiring up some code gen to use the flag, but I got distracted.

Your right about the clang behavior. I'll need to update the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69500/new/

https://reviews.llvm.org/D69500





More information about the llvm-commits mailing list