[PATCH] D69682: [cmake] Remove SVN support from VersionFromVCS.cmake

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 15:39:48 PDT 2019


tstellar marked an inline comment as done.
tstellar added inline comments.


================
Comment at: llvm/cmake/modules/VersionFromVCS.cmake:51
 
 function(get_source_info path revision repository)
+  get_source_info_git("${path}" revision_info repository_info)
----------------
phosek wrote:
> This function just forwards to `get_source_info_git` now, so we could just delete it and rename `get_source_info_git` to `get_source_info`?
Ok, I'll do this before I commt.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69682/new/

https://reviews.llvm.org/D69682





More information about the llvm-commits mailing list