[PATCH] D68271: DWARFDebugLoclists: Make it possible to read relocated addresses

Thu Oct 31 14:04:53 PDT 2019

dblaikie added inline comments.

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:124-127
+        return DWARFDataExtractor(Obj, Obj.getLoclistsSection(),
+                                  Ctx.isLittleEndian(), Obj.getAddressSize());
+      return DWARFDataExtractor(U->getLocSectionData(), Ctx.isLittleEndian(),
+                                Obj.getAddressSize());
----------------
Is this written with a lambda because DWARFDataExtractor isn't assignable? Perhaps it should/could be made assignable?

================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_loclists.s:11-12
+# CHECK-NEXT:        Addr idx 57005 (w/ length 1): DW_OP_reg4 RSI)
+
+
+        .text
----------------
Could you include the source & commands used to build this assembly for reference?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68271/new/

https://reviews.llvm.org/D68271