[PATCH] D68708: [RFC] Adopt Dexter and use it to run debuginfo-tests

Jeremy Morse via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 12:07:09 PDT 2019


Hi,

I'm having auth issues with phab and google accounts right now, so
can't reply on phab,

Thanks for pushing through the python 3 issues!,

On Thu, Oct 31, 2019 at 6:28 PM Adrian Prantl via Phabricator
<reviews at reviews.llvm.org> wrote:
> I don't have time to investigate this right now so I XFAILed the tests on Darwin in 8e406204418895f7b09d1a9a3f8037e741a43968 <https://reviews.llvm.org/rG8e406204418895f7b09d1a9a3f8037e741a43968>. Perhaps the solution is obvious to you, let me know if it isn't, it would be great to revert the XFAILs again!

Exciting -- it's just argparse plus a wrapper, and we've been using
python 3.6 so I wouldn't expect python 3.7 to regress. The "--" is the
positional-argument separator (bottom of the section in [0])
indicating that everything following is a positional argument.

Technically all those '--' separators can be deleted as we're not
doing anything advanced with command lines. It's odd that this proves
to be an incompatibility though.

[0] https://docs.python.org/dev/library/argparse.html#arguments-containing

--
Thanks,
Jeremy


More information about the llvm-commits mailing list