[PATCH] D69676: [WinCFG] Handle constant casts carefully in .gfids emission

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 11:56:49 PDT 2019


efriedma added a comment.

I mentioned this on the bug, but do we care if a reference to a function is optimized away at the MIR level?



================
Comment at: llvm/lib/CodeGen/AsmPrinter/WinCFGuard.cpp:71
+        // constants, such as vtable initializers, to escape the function.
+        if (C->stripPointerCasts() == FnOrCast)
+          Users.push_back(FnUser);
----------------
Does stripPointerCasts do the right thing here?  It can look through multiple levels of casts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69676/new/

https://reviews.llvm.org/D69676





More information about the llvm-commits mailing list