[PATCH] D69675: [scudo][standalone] Fix Secondary bug w/ freelist

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 11:38:22 PDT 2019


morehouse added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/secondary.h:141
+      if (ZeroContents)
+        memset(Ptr, 0, H.BlockEnd - reinterpret_cast<uptr>(Ptr));
+      return Ptr;
----------------
We currently release unconditionally in `deallocate`.  Does this zero-out the memory?

If so, we might only need to zero the first page here, not the whole allocation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69675/new/

https://reviews.llvm.org/D69675





More information about the llvm-commits mailing list