[PATCH] D69671: [llvm-readobj] Change errors to warnings for symbol section name dumping

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: grimar, MaskRay, rupprecht.
Herald added a subscriber: seiya.
Herald added a project: LLVM.

Also only print each such warning once.

LLVM-style output will now print "<?>" for sections it cannot identify, e.g. because the section index is invalid. GNU output continues to print the raw index. In both cases where the st_shndx value is SHN_XINDEX and the index cannot be looked up in the SHT_SYMTAB_SHNDX section (e.g. because it is missing), the symbol is printed like other symbols with st_shndx >= SHN_LORESERVE.

Depends on D69670 <https://reviews.llvm.org/D69670>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69671

Files:
  llvm/test/Object/invalid.test
  llvm/test/tools/llvm-readobj/elf-section-symbols.test
  llvm/test/tools/llvm-readobj/elf-symbol-shndx.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69671.227300.patch
Type: text/x-patch
Size: 17398 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191031/ecdb776c/attachment-0001.bin>