[PATCH] D69656: [IPCP] Bail on extractvalue's with more than 1 index.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 09:14:30 PDT 2019


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Besides the point: I didn't know anyone was still using this pass. Actually I was going to propose to delete it soon. Is there a desire to keep it or would people switch to IP-SCCP and/or the Attributor (assuming they subsume the functionality)? The one reason to keep this pass is that it is simple and "fast" but it's questionable if that is useful if we run either of the other ones anyway.

The patch LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69656/new/

https://reviews.llvm.org/D69656





More information about the llvm-commits mailing list