[PATCH] D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries

[Jeeva P. via Phabricator via llvm-commits]

pjeeva01 added a comment.

@jsji Using setLibcallName to override the generic fun*_massv names with target specific names is feasible. However, it entails extension of ISDNodes to support vector types as well. Furthermore, with the current infrastructure, distinguishing MASSV calls from a list of scalar math, and other runtime library calls will incur the overheads of look up and comparison.

Given that the setLibcallName approach to lowering massv calls involves non-trivial extension to both target-independent and PPC-specific files, and also incurs the aforementioned overhead, I believe a separate pass for lowering is a reasonable approach.

I have addressed rest of the issues pointed out in the last review.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59883/new/

https://reviews.llvm.org/D59883