[compiler-rt] 23a33d4 - Revert "[Builtins] Downgrade duplicate source file warning from a fatal error to a warning."

[Dan Liew via llvm-commits]

Author: Dan Liew
Date: 2019-10-30T16:21:46-07:00
New Revision: 23a33d450b9a426eae7094b16472f8a51fb5488a

URL: https://github.com/llvm/llvm-project/commit/23a33d450b9a426eae7094b16472f8a51fb5488a
DIFF: https://github.com/llvm/llvm-project/commit/23a33d450b9a426eae7094b16472f8a51fb5488a.diff

LOG: Revert "[Builtins] Downgrade duplicate source file warning from a fatal error to a warning."

This reverts commit dc748816e2aec8941d63f8ad07fb82aff6be8af7.

Now that 8ea148dc0cbff33ac3c80cf4273991465479a01e has landed it should
be safe to turning the warning back into a fatal error.

Added: 
    

Modified: 
    compiler-rt/test/builtins/Unit/lit.cfg.py

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/builtins/Unit/lit.cfg.py b/compiler-rt/test/builtins/Unit/lit.cfg.py
index d2cd3305315f..8fdb1a216ee2 100644
--- a/compiler-rt/test/builtins/Unit/lit.cfg.py
+++ b/compiler-rt/test/builtins/Unit/lit.cfg.py
@@ -111,9 +111,7 @@ def build_invocation(compile_flags):
     builtins_source_feature_duplicates.append(builtin_source_feature)
 
 if len(builtins_source_feature_duplicates) > 0:
-  # FIXME(dliew): There's a bug in the build system for powerpc where two definitions of the same
-  # function are present in the library. So just downgrade this to a warning until this is fixed.
-  lit_config.warning(
+  lit_config.fatal(
     'builtins_source_features contains duplicates: {}'.format(
       builtins_source_feature_duplicates)
   )