[PATCH] D69477: [InstCombine] keep assumption before sinking calls

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 30 16:04:47 PDT 2019


jdoerfert added a comment.

In D69477#1727933 <https://reviews.llvm.org/D69477#1727933>, @xbolva00 wrote:

> Is Attributor scheduled in pipeline after the XYZ pass which  removes branch due to llvm.assume?
>
> Attributor should run after InstCombine too.


For now, the Attributor runs once very early (see D69596 <https://reviews.llvm.org/D69596>). Later, we will run the Attributor alternatively/additionally as CG-SCC pass in the "inliner loop". That needs some preparation but it was design to be doable like this from the very beginning. I mean, you will be able to run the Attributor on any IR subset later but there is a little bit of glue code missing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69477/new/

https://reviews.llvm.org/D69477





More information about the llvm-commits mailing list