[PATCH] D69639: Add support for lowering 32-bit/64-bit pointers

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/X86/mixed-ptr-sizes.ll:36-37
+
+; ModuleID = 't.cpp'
+source_filename = "t.cpp"
+target datalayout = "e-m:w-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
----------------
Don't need this


================
Comment at: llvm/test/CodeGen/X86/mixed-ptr-sizes.ll:108
+}
+
+
----------------
Should add some tests with the recognized address spaces and an arbitrary number


================
Comment at: llvm/test/CodeGen/X86/mixed-ptr-sizes.ll:110
+
+!llvm.module.flags = !{!0}
+!llvm.ident = !{!1}
----------------
All the metadata should be removed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69639/new/

https://reviews.llvm.org/D69639