[llvm] f25f3d3 - [X86] Add FIXME comment to merge more of computeZeroableShuffleElements and getTargetShuffleAndZeroables

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 30 11:34:04 PDT 2019


Author: Simon Pilgrim
Date: 2019-10-30T18:30:01Z
New Revision: f25f3d39df42ebcc8a394c8ce85981235a6720b0

URL: https://github.com/llvm/llvm-project/commit/f25f3d39df42ebcc8a394c8ce85981235a6720b0
DIFF: https://github.com/llvm/llvm-project/commit/f25f3d39df42ebcc8a394c8ce85981235a6720b0.diff

LOG: [X86] Add FIXME comment to merge more of computeZeroableShuffleElements and getTargetShuffleAndZeroables

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index d9e38b18d86c..ee80d8136442 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -6712,6 +6712,7 @@ static bool getTargetShuffleMask(SDNode *N, MVT VT, bool AllowSentinelZero,
 /// Decode a target shuffle mask and inputs and see if any values are
 /// known to be undef or zero from their inputs.
 /// Returns true if the target shuffle mask was decoded.
+/// FIXME: Merge this with computeZeroableShuffleElements?
 static bool getTargetShuffleAndZeroables(SDValue N, SmallVectorImpl<int> &Mask,
                                          SmallVectorImpl<SDValue> &Ops,
                                          APInt &KnownUndef, APInt &KnownZero) {


        


More information about the llvm-commits mailing list