[PATCH] D59078: Fix missing memcpy, memmove and memset tail calls

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.

Yeah. LGTM. Thanks for carrying this forward!



================
Comment at: llvm/lib/CodeGen/Analysis.cpp:617
+static bool isPointerBitcastEqualTo(const Value *A, const Value *B) {
+  assert(A); assert(B);
+
----------------
I don't think these two asserts are required if you wanted to leave them out. It's pretty much implied from the signature that the two values will not be null.

If you do want to keep them in, run clang format and add a message to the asserts. Something like:
assert(a && b && "Expected non-null inputs!");


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59078/new/

https://reviews.llvm.org/D59078