[PATCH] D69558: [ObjectYAML] - Redefine LLVM_YAML_IS_SEQUENCE_VECTOR(llvm::yaml::Hex*) as LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 30 04:13:38 PDT 2019


grimar planned changes to this revision.
grimar added a comment.

Returning to this, LLDB uses YAMLs in the old form for inputs. But this patch only affects output. We accept both the old and the new way for describing arrays.
(MachO tests in this diff do the same, they read the old style and check the YAML produced which is in a new style)
So, LDLB tests are fine.

But there is another problem: this patch never tests we can **read ** arrays in the new style.
I am going to add few tests to Support/YAMLIOTest.cpp and update this diff.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69558/new/

https://reviews.llvm.org/D69558





More information about the llvm-commits mailing list