[PATCH] D69565: [update_cc_test_checks.py] Use -ast-dump=json to get mangled name

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added inline comments.


================
Comment at: llvm/utils/update_cc_test_checks.py:46
+  # Use clang's JSON AST dump to get the mangled name
+  json_dump_args = [args.clang, *clang_args]
+  json_dump_args += ['-fsyntax-only', '-o', '-']
----------------
arichardson wrote:
> MaskRay wrote:
> > `json_dump_args = [args.clang, *clang_args, '-fsyntax-only', '-o', '-']`
> I think this syntax requires python 3.5. Is that a reasonable baseline?
> 
> For me 3.5 is the oldest version I use this script with. However, that might not be true for everyone? 
Never mind, subprocess.run() is already python 3.5 only. I'll make that change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69565/new/

https://reviews.llvm.org/D69565