[PATCH] D68852: [Attributor] Pointer privatization attribute (argument promotion)

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert marked 2 inline comments as done.
jdoerfert added inline comments.


================
Comment at: llvm/test/Transforms/ArgumentPromotion/control-flow2.ll:27-31
+define i32 @foo(i1 %C) {
+; ALL-LABEL: define {{[^@]+}}@foo
+; ALL-SAME: (i1 [[C:%.*]])
+; ALL-NEXT:    [[X:%.*]] = call i32 @callee(i1 [[C:%.*]], i32 17)
+; ALL-NEXT:    ret i32 [[X]]
----------------
lebedev.ri wrote:
> This is why i'm really pushing on using `--check-prefixes=ALL,ARGPROMOTION` from the getgo :[
Agreed.


================
Comment at: llvm/test/Transforms/ArgumentPromotion/control-flow2.ll:35
   store i32 17, i32* %A
-  %X = call i32 @callee( i1 false, i32* %A )              ; <i32> [#uses=1]
+  %X = call i32 @callee( i1 %C, i32* %A )              ; <i32> [#uses=1]
   ret i32 %X
----------------
lebedev.ri wrote:
> I strongly believe you want to precommit test changes+regeneration first.
I will update the test lines after the D68766 update. Do you want me to split test changes, e.g., that remove UB, as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68852/new/

https://reviews.llvm.org/D68852