[PATCH] D47561: [CMake] Unify handling of libxml2 with other libraries

[Petr Hosek via Phabricator via llvm-commits]

phosek marked an inline comment as not done.
phosek added inline comments.


================
Comment at: llvm/cmake/config-ix.cmake:150
         include_directories(${LIBXML2_INCLUDE_DIR})
-        set(LIBXML2_LIBS "xml2")
       endif()
     endif()
----------------
delcypher wrote:
> If `LLVM_ENABLE_LIBXML2` is enabled but we don't find libxml2 then we should emit an error.
This is already handled by the check below (when `LLVM_ENABLE_LIBXML2` is set to `FORCE_ON`), we could check it to emit an error even when it's set just to `ON` but I don't know whether that's going to break any existing users?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47561/new/

https://reviews.llvm.org/D47561