[PATCH] D69477: [InstCombine] keep assumption before sinking calls

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:3159
+      if (CS->paramHasAttr(Idx, Attribute::NonNull) ||
+          (!llvm::NullPointerIsDefined(CS->getParent()->getParent()) &&
+           CS->paramHasAttr(Idx, Attribute::Dereferenceable))) {
----------------
CS-->getFunction()


================
Comment at: llvm/test/Transforms/InstCombine/Assume-Remplacing-Call.ll:5
+
+define i32 @test_sink_remplacement1(i8* %p) {
+;CHECK-LABEL: @test_sink_remplacement1(
----------------
xbolva00 wrote:
> typo //remplacement//
Also typo in “Assume-Remplacing-Call.ll” (and please use lowercase)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69477/new/

https://reviews.llvm.org/D69477