[PATCH] D69411: [MC] Calculate difference of symbols in two fragments when possible

Tue Oct 29 11:32:32 PDT 2019

jcai19 added a comment.

In D69411#1725298 <https://reviews.llvm.org/D69411#1725298>, @peter.smith wrote:

> When I run check-llvm with this patch applied I get 7 failures:
>
>   LLVM :: DebugInfo/Mips/delay-slot.ll
>   LLVM :: DebugInfo/Mips/dsr-fixed-objects.ll
>   LLVM :: DebugInfo/Mips/dsr-non-fixed-objects.ll
>   LLVM :: DebugInfo/Mips/fn-call-line.ll
>   LLVM :: MC/AsmParser/directive_fill_2.s
>   LLVM :: MC/MachO/reloc-diff.s
>   LLVM :: MC/X86/expand-var.s
>
> This is applied to master revision 12c9ffd108345f643df98dfa8653af1a4311ed86 <https://reviews.llvm.org/rG12c9ffd108345f643df98dfa8653af1a4311ed86> and the tests don't fail with master. Is it possible your most recent changes have broken something? I'm testing a release build of LLVM with clang, assertions enabled.

Yes, I am aware of failure on  LLVM :: MC/MachO/reloc-diff.s and working on it, but my build does not have assertions on so I haven't seen the other failures. Thanks for verifying, I will take a look on them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69411/new/

https://reviews.llvm.org/D69411