[llvm] 1765f31 - [globalisel][docs] Rewrite the pipeline overview
Daniel Sanders via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 29 11:23:23 PDT 2019
Author: Daniel Sanders
Date: 2019-10-29T11:21:24-07:00
New Revision: 1765f31f5adf91c794ce4ddfa69afd62c0592767
URL: https://github.com/llvm/llvm-project/commit/1765f31f5adf91c794ce4ddfa69afd62c0592767
DIFF: https://github.com/llvm/llvm-project/commit/1765f31f5adf91c794ce4ddfa69afd62c0592767.diff
LOG: [globalisel][docs] Rewrite the pipeline overview
Summary:
Rewrite the pipeline overview to be more focused on the structure and
flexibility as well as highlight the increased usefulness of
MachineVerifier and increased testability resulting from the smaller
incremental passes approach.
The diagrams are lifted from the slides for the LLVMDev 2019 talk
'Generating Optimized Code with GlobalISel' and adapted to be readable on
the white background used in the docs.
Reviewers: volkan
Subscribers: rovka, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69456
Added:
llvm/docs/GlobalISel/pipeline-overview-customized.png
llvm/docs/GlobalISel/pipeline-overview-with-combiners.png
llvm/docs/GlobalISel/pipeline-overview.png
llvm/docs/GlobalISel/testing-pass-level.png
llvm/docs/GlobalISel/testing-unit-level.png
Modified:
llvm/docs/GlobalISel/Pipeline.rst
Removed:
################################################################################
diff --git a/llvm/docs/GlobalISel/Pipeline.rst b/llvm/docs/GlobalISel/Pipeline.rst
index 2f9bc93c9b5a..ee5b63788128 100644
--- a/llvm/docs/GlobalISel/Pipeline.rst
+++ b/llvm/docs/GlobalISel/Pipeline.rst
@@ -3,80 +3,135 @@
Core Pipeline
=============
-There are four required passes, regardless of the optimization mode:
-
.. toctree::
- :maxdepth: 1
+ :hidden:
IRTranslator
Legalizer
RegBankSelect
InstructionSelect
-Additional passes can then be inserted at higher optimization levels or for
-specific targets. For example, to match the current SelectionDAG set of
-transformations: MachineCSE and a better MachineCombiner between every pass.
-
-``NOTE``:
-In theory, not all passes are always necessary.
-As an additional compile-time optimization, we could skip some of the passes by
-setting the relevant MachineFunction properties. For instance, if the
-IRTranslator did not encounter any illegal instruction, it would set the
-``legalized`` property to avoid running the :ref:`milegalizer`.
-Similarly, we considered specializing the IRTranslator per-target to directly
-emit target-specific MI.
-However, we instead decided to keep the core pipeline simple, and focus on
-minimizing the overhead of the passes in the no-op cases.
+The core pipeline of GlobalISel is:
-.. _maintainability-verifier:
+.. image:: pipeline-overview.png
-MachineVerifier
----------------
+The four passes shown in the diagram consist of:
+
+:doc:`IRTranslator`
+
+ Converts :doc:`LLVM-IR <../LangRef>` into :doc:`gMIR (Generic MIR) <GMIR>`.
+ This is largely a direct translation and has little target customization.
+ It's somewhat analogous to SelectionDAGBuilder but builds a flavour of MIR
+ called gMIR instead of a specialized representation. gMIR uses exactly the
+ same data structures as MIR but has more relaxed constraints. For example,
+ a virtual register may be constrained to a particular type without also
+ constraining it to a specific register class.
+
+:doc:`Legalizer`
+
+ Replaces unsupported operations with supported ones. In other words, it shapes
+ the gMIR to suit what the backend can support. There is a very small set of
+ operations which targets are required to support but aside from that targets
+ can shape the MIR as they wish.
+
+:doc:`Register Bank Selector <RegBankSelect>`
+
+ Binds virtual registers to register banks. This pass is intended to minimize
+ cross-register-bank copies by clustering portions of the MIR together.
+
+:doc:`Instruction Select <InstructionSelect>`
+
+ Select target instructions using the gMIR. At this point, the gMIR has been
+ constrained enough that it becomes MIR.
+
+Although we tend to talk about them as distinct passes, it should be noted that
+there's a good deal of flexibility here and it's ok for things to happen
+earlier than described below. For example, it's not unusual for the legalizer to
+legalize an intrinsic directly to a target instruction. The concrete
+requirement is that the following additional constraints are preserved after
+each of these passes:
+
+IRTranslator
-The pass approach lets us use the ``MachineVerifier`` to enforce invariants.
-For instance, a ``regBankSelected`` function may not have gvregs without
-a bank.
+ The representation must be gMIR, MIR, or a mixture of the two after this pass.
+ The majority will typically be gMIR to begin with but later passes will
+ gradually transition the gMIR to MIR.
-``TODO``:
-The ``MachineVerifier`` being monolithic, some of the checks we want to do
-can't be integrated to it: GlobalISel is a separate library, so we can't
-directly reference it from CodeGen. For instance, legality checks are
-currently done in RegBankSelect/InstructionSelect proper. We could #ifdef out
-the checks, or we could add some sort of verifier API.
+Legalizer
+ No illegal operations must remain or be introduced after this pass.
-.. _maintainability:
+Register Bank Selector
-Maintainability
-===============
+ All virtual registers must have a register bank assigned after this pass.
-.. _maintainability-iterative:
+Instruction Select
+
+ No gMIR must remain or be introduced after this pass. In other words, we must
+ have completed the conversion from gMIR to MIR.
+
+In addition to these passes, there are also some optional passes that perform
+an optimization. The current optional passes are:
+
+Combiner
+
+ Replaces patterns of instructions with a better alternative. Typically, this
+ means improving run time performance by replacing instructions with faster
+ alternatives but Combiners can also focus on code size or other metrics.
+
+Additional passes such as these can be inserted to support higher optimization
+levels or target specific needs. A likely pipeline is:
+
+.. image:: pipeline-overview-with-combiners.png
+
+Of course, combiners can be inserted in other places too. Also passes can be
+replaced entirely so long as their task is complete as shown in this (more
+customized) example pipeline.
+
+.. image:: pipeline-overview-customized.png
+
+.. _maintainability-verifier:
+
+MachineVerifier
+---------------
-Iterative Transformations
--------------------------
+The pass approach lets us use the ``MachineVerifier`` to enforce invariants
+that are required beyond certain points of the pipeline. For example, a
+function with the ``legalized`` property can have the ``MachineVerifier``
+enforce that no illegal instructions occur. Similarly, a
+``regBankSelected`` function may not have virtual registers without a register
+bank assigned.
-Passes are split into small, iterative transformations, with all state
-represented in the MIR.
+.. note::
-This
diff ers from SelectionDAG (in particular, the legalizer) using various
-in-memory side-tables.
+ For layering reasons, ``MachineVerifier`` isn't able to be the sole verifier
+ in GlobalISel. Currently some of the passes also perform verification while
+ we find a way to solve this problem.
+ The main issue is that GlobalISel is a separate library, so we can't
+ directly reference it from CodeGen.
-.. _maintainability-mir:
+Testing
+-------
-MIR Serialization
------------------
+The ability to test GlobalISel is significantly improved over SelectionDAG.
+SelectionDAG is something of a black box and there's a lot going on inside it.
+This makes it
diff icult to write a test that reliably tests a particular aspect
+of its behaviour. For comparison, see the following diagram:
-.. FIXME: Update the MIRLangRef to include GMI additions.
+.. image:: testing-pass-level.png
-:ref:`gmir` is serializable (see :doc:`../MIRLangRef`).
-Combined with :ref:`maintainability-iterative`, this enables much finer-grained
-testing, rather than requiring large and fragile IR-to-assembly tests.
+Each of the grey boxes indicates an opportunity to serialize the current state
+and test the behaviour between two points in the pipeline. The current state
+can be serialized using ``-stop-before`` or ``-stop-after`` and loaded using
+``-start-before``, ``-start-after``, and ``-run-pass``.
-The current "stage" in the :ref:`pipeline` is represented by a set of
-``MachineFunctionProperties``:
+We can also go further still, as many of GlobalISel's passes are readily unit
+testable:
-* ``legalized``
-* ``regBankSelected``
-* ``selected``
+.. image:: testing-unit-level.png
+It's possible to create an imaginary target such as in `LegalizerHelperTest.cpp <https://github.com/llvm/llvm-project/blob/93b29d3882baf7df42e4e9bc26b977b00373ef56/llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp#L28-L57>`_
+and perform a single step of the algorithm and check the result. The MIR and
+FileCheck directives can be embedded using strings so you still have access to
+the convenience available in llvm-lit.
diff --git a/llvm/docs/GlobalISel/pipeline-overview-customized.png b/llvm/docs/GlobalISel/pipeline-overview-customized.png
new file mode 100644
index 000000000000..a6512198eb61
Binary files /dev/null and b/llvm/docs/GlobalISel/pipeline-overview-customized.png
diff er
diff --git a/llvm/docs/GlobalISel/pipeline-overview-with-combiners.png b/llvm/docs/GlobalISel/pipeline-overview-with-combiners.png
new file mode 100644
index 000000000000..3cff8eab8fc7
Binary files /dev/null and b/llvm/docs/GlobalISel/pipeline-overview-with-combiners.png
diff er
diff --git a/llvm/docs/GlobalISel/pipeline-overview.png b/llvm/docs/GlobalISel/pipeline-overview.png
new file mode 100644
index 000000000000..88d691af5b50
Binary files /dev/null and b/llvm/docs/GlobalISel/pipeline-overview.png
diff er
diff --git a/llvm/docs/GlobalISel/testing-pass-level.png b/llvm/docs/GlobalISel/testing-pass-level.png
new file mode 100644
index 000000000000..ab5b6fbdee2a
Binary files /dev/null and b/llvm/docs/GlobalISel/testing-pass-level.png
diff er
diff --git a/llvm/docs/GlobalISel/testing-unit-level.png b/llvm/docs/GlobalISel/testing-unit-level.png
new file mode 100644
index 000000000000..26503e4a19eb
Binary files /dev/null and b/llvm/docs/GlobalISel/testing-unit-level.png
diff er
More information about the llvm-commits
mailing list