[PATCH] D69416: [Examples] Add IRTransformations directory to examples.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 29 06:34:26 PDT 2019


fhahn added a comment.

In D69416#1722297 <https://reviews.llvm.org/D69416#1722297>, @andwar wrote:

> I think that having a reference to these examples somewhere in the official docs would be very helpful. Maybe somewhere here: http://llvm.org/docs/WritingAnLLVMPass.html?


Agreed, we should integrate the new examples in the official docs. WritingAnLLVMPass seems like a good candidate, but currently it seems a bit crowded already and I'd like to think about how to best integrate it a bit more carefully.

> [nit] I'd keep the names of files and passes shorter and remove 'Tutorial' from names. IMHO it doesn't really add much in terms of self-documentation, yet makes everything a bit harder to read.

Yep, it should already be obvious from the path and the tutorial part seems redundant. But I have no strong feelings either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69416/new/

https://reviews.llvm.org/D69416





More information about the llvm-commits mailing list