[PATCH] D69501: [CommandLine] Add inline ArgName printing
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 29 05:48:05 PDT 2019
jhenderson added a comment.
I think adding an extra constructor argument to `PrintArg` might be the way forward. There are several places that add additional spaces before the `PrintArg` call (see e.g. `printGenericOptionDiff` and `printOptionInfo` in `generic_parser_base`), where the spaces could be combined with the two implicitly added currently, I think by specifying, e.g. "4" as the extra argument. The alternative is to go the other way and remove the spaces that `PrintArg` automatically adds, and then add them in the relevant places explicitly. I'm not sure how clean that would be though.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69501/new/
https://reviews.llvm.org/D69501
More information about the llvm-commits
mailing list