[PATCH] D69519: [InstCombine] make icmp vector canonicalization safe for constant with undef elements

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:5190
         return llvm::None;
+      SafeReplacementConstant = CI;
     }
----------------
lebedev.ri wrote:
> This will result in the last one being used
Good catch. Yes, the test coverage isn't sufficient. I'll add tests before splitting/committing/fixing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69519/new/

https://reviews.llvm.org/D69519