[PATCH] D68771: [llvm-readelf] - Do not enter an infinite loop when printing histogram.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 29 04:14:48 PDT 2019


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/elf-hash-histogram.test:45
+  Data:    ELFDATA2LSB
+  Type:    ET_REL
+  Machine: EM_386
----------------
Nit: This should probably have been ET_DYN or ET_EXEC. Program headers and dynamic sections in relocatable objects are... odd :) No need to change it again though if you don't want to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68771/new/

https://reviews.llvm.org/D68771





More information about the llvm-commits mailing list