[PATCH] D69552: Move floating point related entities to namespace level

Serge Pavlov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 29 00:30:49 PDT 2019


sepavloff created this revision.
sepavloff added reviewers: kpn, andrew.w.kaylor.
Herald added subscribers: hiraditya, mgorny.
Herald added a project: LLVM.

Enumerations that describe rounding mode and exception behavior were
defined inside ConstrainedFPIntrinsic. It makes sense to use the same
definitions to represent the same properties in other cases, not only
in constrained intrinsics. It was however inconvenient as required to
include constrained intrinsics definitions even if they were not needed.
Also using long scope prefix reduced readability.

This change moves these definitioins to the namespace llvm.
No functional changes.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69552

Files:
  llvm/include/llvm/IR/FloatingPoint.h
  llvm/include/llvm/IR/IRBuilder.h
  llvm/include/llvm/IR/IntrinsicInst.h
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/IR/CMakeLists.txt
  llvm/lib/IR/FloatingPoint.cpp
  llvm/lib/IR/IntrinsicInst.cpp
  llvm/unittests/IR/IRBuilderTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69552.226846.patch
Type: text/x-patch
Size: 21547 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191029/a64bb3f5/attachment.bin>


More information about the llvm-commits mailing list